Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sim] Log/plot better classifier metrics precision, recall, F-score #726

Closed
trentmc opened this issue Mar 2, 2024 · 0 comments · Fixed by #780
Closed

[Sim] Log/plot better classifier metrics precision, recall, F-score #726

trentmc opened this issue Mar 2, 2024 · 0 comments · Fixed by #780
Assignees
@trentmc
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Mar 2, 2024 •
edited
Loading

Good sklearn refs:
@trentmc trentmc added the Type: Enhancement New feature or request label Mar 2, 2024
trentmc added a commit that referenced this issue Mar 2, 2024
@trentmc
Fix #722 #725 #723 #724 #647 #726 Improve classifier accuracy & insight
7ee28a0
@trentmc trentmc mentioned this issue Mar 2, 2024
Merged
3 tasks
@trentmc trentmc self-assigned this Mar 12, 2024
@trentmc trentmc changed the title [Sim] Log/plot better classifier metrics F-score, precision, recall. [Sim] Log/plot better classifier metrics precision, recall, F-score Mar 12, 2024
trentmc added a commit that referenced this issue Mar 12, 2024
@trentmc
Fix #726: [Sim] Log/plot better classifier metrics precision, recall,…
2a50c2a 
… F-score
@trentmc trentmc mentioned this issue Mar 12, 2024
Merged
trentmc added a commit that referenced this issue Mar 12, 2024
@trentmc
Fix #726: [Sim] Log/plot better metrics: f1, precision, recall (PR #780)
b8dddec 
Fix #726

Specifically:
- Update SimState: removed some redundant storage. Added ClassifierMetrics, to avoid calculating the metrics themselves in both SimEngine and SimPlotter.
- Measure f1, precision recall
- Log ""
- Plot "", including a small rearrange of the overall plot's grid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentmc trentmc

Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #726: [Sim] Log/plot better metrics: f1, precision, recall oceanprotocol/pdr-backend
1 participant
@trentmc