Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sim] Refactor plot code in sim_engine #750

Closed
trentmc opened this issue Mar 6, 2024 · 0 comments · Fixed by #755
Closed

[Sim] Refactor plot code in sim_engine #750

trentmc opened this issue Mar 6, 2024 · 0 comments · Fixed by #755
Assignees
@trentmc
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Mar 6, 2024 •
edited
Loading

#749 is "Output sim_engine plots -> streamlit -> webapp".

But that will be hard unless the plot's code is in better shape. Right now it's one big function for all the plots.

I know what needs doing, I'll clean it up -- Trent
@trentmc trentmc added the Type: Enhancement New feature or request label Mar 6, 2024
@trentmc trentmc self-assigned this Mar 6, 2024
@trentmc trentmc mentioned this issue Mar 6, 2024
Closed
3 tasks
trentmc added a commit that referenced this issue Mar 6, 2024
@trentmc
Fix #750: [Sim] Refactor plots in sim_engine
caaab09
@trentmc trentmc mentioned this issue Mar 6, 2024
Merged
@trentmc trentmc changed the title [Sim] Refactor plots in sim_engine [Sim] Refactor plot code in sim_engine Mar 6, 2024
trentmc added a commit that referenced this issue Mar 6, 2024
@trentmc
Fix #750: [Sim] Refactor plot code in sim_engine (PR #755)
45bdf2e 
* split sim_engine.py into 3 modules: sim_engine.py, sim_plotter.py, sim_state.py. 
* each plot is modularized into its own method
trentmc added a commit that referenced this issue Mar 7, 2024
@trentmc
Extend work from #750: [Sim] Refactor plot code in sim_engine
b46bc4d
trentmc added a commit that referenced this issue Mar 7, 2024
@trentmc
Extend work from #750: [Sim] Refactor plot code in sim_engine (PR #760)
47b9249 
Even cleaner! What I did here: rename axes to the names of the plots themselves. This in turn allowed me to reference axes within the plot, rather than passing it in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentmc trentmc

Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #750: [Sim] Refactor plot code in sim_engine oceanprotocol/pdr-backend
1 participant
@trentmc