Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GQL update process fails on slots tables #1040

Merged
merged 3 commits into from
May 14, 2024
Merged

Fix GQL update process fails on slots tables #1040

merged 3 commits into from
May 14, 2024

Conversation

KatunaNorbert
Copy link
Member

Fixes #1036.

@KatunaNorbert KatunaNorbert marked this pull request as ready for review May 14, 2024 15:31
@idiom-bytes
Copy link
Member

idiom-bytes commented May 14, 2024 •
edited
Loading

I have documented the remaining work required for us to deprecate PredictSlots altogether. #1041
This is not priority

I wrote this ticket so we can close/merge this PR (1040) without having to improve it further.

@idiom-bytes idiom-bytes self-requested a review May 14, 2024 20:09
idiom-bytes
idiom-bytes approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed it and it looks good.

I also created a ticket so we can in the future, remove PredictSlot. It's mainly being used by the pdr-backend/app/ module.

@idiom-bytes idiom-bytes merged commit 1e89d6f into issue685-duckdb-integration May 14, 2024
4 checks passed
@idiom-bytes idiom-bytes deleted the issue1036-fix-gql-fails-on-slots branch May 14, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idiom-bytes idiom-bytes idiom-bytes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KatunaNorbert @idiom-bytes