Add an interface class for PredictoorHelper contract and tests #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trizin
changed the title
trentmc
requested changes
Aug 31, 2023
pdr_backend/models/erc721.py
Outdated
| @@ -0,0 +1,25 @@ | |||
| from typing import Union | |||
There was a problem hiding this comment.
Q: should this be called erc721.py (class ERC721) or data_nft.py (class DataNft)?
Investigate: well what does it do here?
Result: it's calling addToCreateERC20List. DataNft has this functionality, but canonical ERC721 does not.
Answer to Q: call it data_nft.py (class DataNft)
There was a problem hiding this comment.
I realized there's already a DataNft class and a data_nft.py file and moved the new function there :D thanks!
trentmc
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Changes proposed in this PR: