#148 - Add documentation for env vars #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trizin
changed the title
trentmc
requested changes
Sep 8, 2023
READMEs/env-vars.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| # Environment Variables | |||
There was a problem hiding this comment.
Feedback:
-
Please call this file envvars.md, not env-vars.md. Less annoying for us to work with.
-
Please link to this from README.md, in the bottom section.
-
Please link to this from each agent-specific README; from the backend-dev README; and from the frontend-dev README. Keep it concise.
-
There actually is a bit of documentation on the filter envvars, at the bottom of subgraph.md. To reconcile (and avoid DRY): in subgraph.md, just mention the 4 envvars, and then link to envvars.md.
trentmc
approved these changes
Sep 13, 2023
trizin
deleted the
issue148-properly-document-env-vars-used-in-pdr-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
Changes proposed in this PR: