Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#176 - trueval should use close prices #177

Merged
merged 3 commits into from
Sep 26, 2023
Merged

#176 - trueval should use close prices #177

merged 3 commits into from
Sep 26, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Sep 26, 2023 •
edited
Loading

Fixes #176

Changes proposed in this PR:

  • Go back one candle and use close prices in get trueval
  • Update tests

@trizin trizin linked an issue Sep 26, 2023 that may be closed by this pull request
Trueval should use close price #176
Closed
@trizin trizin marked this pull request as ready for review September 26, 2023 11:21
@trizin trizin requested a review from trentmc September 26, 2023 11:21
@trizin trizin merged commit 010b0f5 into main Sep 26, 2023
5 checks passed
@trizin trizin deleted the issue176-trueval-should-use-close-price branch September 26, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trueval should use close price
2 participants
@trizin @trentmc