Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dfbuyer] Fix expected consume calculation #181

Merged
merged 3 commits into from
Sep 28, 2023
Merged

[dfbuyer] Fix expected consume calculation #181

merged 3 commits into from
Sep 28, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Sep 28, 2023

Fixes #180

Changes proposed in this PR:

  • Start counting current interval from 1
  • Add comprehensive tests for get expected consume function.

@trizin trizin linked an issue Sep 28, 2023 that may be closed by this pull request
DFBuyer expected consume calculation is incorrect #180
Closed
@trizin trizin marked this pull request as ready for review September 28, 2023 12:39
@trizin trizin requested a review from trentmc September 28, 2023 12:39
@trizin trizin merged commit 0bfab8d into main Sep 28, 2023
5 checks passed
@trizin trizin deleted the issue180-dfbuyer-expected-consume-calculation-is-incorrect branch September 28, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DFBuyer expected consume calculation is incorrect
2 participants
@trizin @trentmc