Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #657: Float being interpreted as integer #669

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Fix #657: Float being interpreted as integer #669

merged 5 commits into from
Feb 28, 2024

Conversation

idiom-bytes
Copy link
Member

Fixes #657

Changes proposed in this PR:

  • Improve upstream ccxt & ohclv checks such that no floats can be entered as timestamps
  • Improve tests that show that floats are handled correctly before being pushed into a pl.DataFrame

@idiom-bytes idiom-bytes marked this pull request as draft February 23, 2024 06:23
@kdetry
Copy link
Contributor

kdetry commented Feb 23, 2024

I fixed the test issue

@idiom-bytes idiom-bytes marked this pull request as ready for review February 24, 2024 01:30
@idiom-bytes idiom-bytes merged commit 50119b7 into main Feb 28, 2024
5 checks passed
@idiom-bytes idiom-bytes deleted the issue657-ohlcv-float-as-integer branch February 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdetry kdetry kdetry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug, lake] pl.Dataframe constructor - 'float' object cannot be interpreted as an integer
2 participants
@idiom-bytes @kdetry