#697 - Automatically claim payouts for previous epochs #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uts-for-previous-epochs
…uts-for-previous-epochs
…vious-epochs' of github.com:oceanprotocol/pdr-backend into issue697-predictoor-automatically-claim-payouts-for-previous-epochs
…vious-epochs' of https://github.com/oceanprotocol/pdr-backend into issue697-predictoor-automatically-claim-payouts-for-previous-epochs
trentmc
requested changes
Mar 1, 2024
trentmc
requested changes
Mar 1, 2024
…uts-for-previous-epochs
trentmc
reviewed
Mar 2, 2024
trentmc
requested changes
Mar 2, 2024
| @@ -63,6 +63,21 @@ def test_predictoor_ss_test_dict(): | |||
| assert d["aimodel_ss"]["input_feeds"] == ["binance ETH/USDT c 1h"] | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
You don't need a dedicated test for this. It adds more complexity than needed.
Rather, incorporate this into the existing tests surgically.
pdr_backend/ppss/web3_pp.py
Outdated
| @@ -336,6 +336,9 @@ def get_current_epoch(self) -> int: | |||
| def set_token(self, web3_pp): | |||
| pass | |||
|
|
|||
| def s_start_payouts(self) -> int: | |||
There was a problem hiding this comment.
This looks like it's an addition to a mock predictoor_contract object. Not the correct place. If it were to be added, it should be an addition to a mock predictoor_ss object
trentmc
approved these changes
Mar 3, 2024
trizin
deleted the
issue697-predictoor-automatically-claim-payouts-for-previous-epochs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697
Changes proposed in this PR: