Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #684: [Sim] Change 1d profit scatterplots to 2d #705

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Fix #684: [Sim] Change 1d profit scatterplots to 2d #705

merged 4 commits into from
Mar 1, 2024

Conversation

trentmc
Copy link
Member

@trentmc trentmc commented Mar 1, 2024 •
edited
Loading

Fixes #684

Also:

  • Fix #707 [Linter bug] Pylint failures in safe_fetch_ohlcv_dydx. Why here: it was causing my CI to fail, and easy to fix
  • For #547 Eth/Weth currency_types: (a) Move tests from test_mathutil.py to new dedicated test module test_currency_types.py. (b) Add support for unary +/- operators (c) Add tests for math operators +, -, *, /, and unary +/-. Why here: because sim_engine uses it

@trentmc trentmc merged commit c9fc5c3 into main Mar 1, 2024
5 checks passed
@trentmc trentmc deleted the issue684-scatter branch March 1, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Linter bug] Pylint failures in safe_fetch_ohlcv_dydx [Sim] Change 1d profit scatterplots to 2d
1 participant
@trentmc