Improve social widget profile list #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the list of profiles manageable without replacing the widget. The list of profiles couldn't be modified once the widget was created. It had to be replaced by a new one and set up again. Make the display icon configurable for each profile. The icon name and style prefix was tied to the profile key. These rules requires to modify the code instead of its configuration to cope with: - Icon names that differ from the profile key. - Icons not from the brands style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the list of profiles manageable without replacing the widget.
The list of profiles couldn't be modified once the widget was created.
It had to be replaced by a new one and set up again.
Make the display icon configurable for each profile.
The icon name and style prefix was tied to the profile key. These rules
require to modify the code instead of its configuration to cope with: