Skip to content

Commit

Permalink
Add remaining fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ocelotl committed Aug 6, 2020
1 parent 7994102 commit 36dd87c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ class ScopeShim(opentracing.Scope):
def __init__(self, manager, span, span_cm=None):
super().__init__(manager, span)
self._span_cm = span_cm
self._token = attach(set_value("scope_shim", self))
attach(set_value("scope_shim", self))

# TODO: Change type of `manager` argument to `opentracing.ScopeManager`? We
# need to get rid of `manager.tracer` for this.
Expand Down Expand Up @@ -395,8 +395,6 @@ def close(self):
else:
self._span.unwrap().end()

detach(self._token)


class ScopeManagerShim(opentracing.ScopeManager):
"""Implements :class:`opentracing.ScopeManager` by setting and getting the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -532,8 +532,6 @@ def test_extract_empty_context_returns_invalid_context(self):
try:
carrier = {}

from ipdb import set_trace
set_trace()
ctx = self.shim.extract(opentracing.Format.HTTP_HEADERS, carrier)
self.assertEqual(ctx.unwrap(), trace.INVALID_SPAN_CONTEXT)
finally:
Expand Down

0 comments on commit 36dd87c

Please sign in to comment.