Add RT Summary Feature to IRCBot #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanhs
reviewed
Oct 3, 2021
|
|
||
|
|
||
| def show_tickets(bot, date): | ||
| """Show RT tickets that need responses.""" |
There was a problem hiding this comment.
I thought about this a bit, and I think the heuristic for "needs responses most" are the oldest tickets in a queue.
If someone submits a ticket today, its usually ok if we take a day to respond, but if its been a week we really should respond ASAP.
There was a problem hiding this comment.
that is a much better idea!
ircbot/plugin/rt_summary.py
Outdated
| from ocflib.infra.rt import RtTicket | ||
|
|
||
| NUM_ITER = 10 | ||
| NUM_LIST = 10500 |
There was a problem hiding this comment.
I think I see why this is 10500, but it probably deserves a comment above it on why it is 10500 (that's a recentish starting point to start searching from)
There was a problem hiding this comment.
yeah, hopefully we can figure out how to use the REST feature to find the most recent ticket instead. for now this should work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on with lmathias during hack day. Definitely want to figure out how to efficiently get the rt number for the latest ticket so we don't waste time finding it. I wanted to merge this pr to do a preliminary test in the #service-comm channel.