add mirrors SQL schema #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abizer
commented
May 20, 2017
| `down` bigint(20) NOT NULL | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=latin1; | ||
|
|
||
| CREATE VIEW `mirrors_public` AS |
There was a problem hiding this comment.
superfluous but done to maintain consistency with granting select to anonymous on public views only
There was a problem hiding this comment.
seems reasonable to me, explicit is better than implicit and all that other zen
chriskuehl
approved these changes
May 20, 2017
| `down` bigint(20) NOT NULL | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=latin1; | ||
|
|
||
| CREATE VIEW `mirrors_public` AS |
There was a problem hiding this comment.
seems reasonable to me, explicit is better than implicit and all that other zen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure where to put this since the rest of ocfstats is documented in labstats but all the functions using this are in ocfweb