Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mount for config with secrets #9

Merged
merged 2 commits into from
Apr 23, 2020
Merged

add mount for config with secrets #9

merged 2 commits into from
Apr 23, 2020

Conversation

ja5087
Copy link
Member

@ja5087 ja5087 commented Apr 21, 2020 •
edited

This is needed to store the password for WEBIRC in #8. It should mount on top of the config.js copied in.

@ja5087 ja5087 requested a review from cg505 April 21, 2020 09:15
cg505
cg505 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a comment at the top of the config.js in this repository to point out that this is not the one that is used in production

@ja5087 ja5087 merged commit 712a393 into master Apr 23, 2020
@cg505 cg505 mentioned this pull request Apr 23, 2020
Closed
@cg505 cg505 deleted the k8s-mount-secret-cfg branch April 23, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cg505 cg505 cg505 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ja5087 @cg505