makeservices: makemysql automatic wp db pass

[gundralaa]

Modified makemysql and makemysql-real to automatically update wp db pass if pass is reset

[dkess]

This approach breaks an important constraint of our current system-- we don't want users to be able to choose their database passwords.

How I would recommend doing it: makemysql-real generate the password, but capture the password from stdout (see https://github.com/ocf/utils/blob/master/makeservices/easywp#L60 for an example of how to do this), and pass that into wp config. This also means you won't have to juggle temporary files.

[jvperrin]

I think there's also a SQL injection issue here, in that accepting user input and then running a SQL query without using a prepared statement or other safeguard means that arbitrary queries can be made, which would be a big problem.

[dkess]

Why are you throwing out this error? Silent failures can create a lot of confusion.

[gundralaa]

I wanted to make sure the script didn't interfere with other scripts that use the makemysql command. Ill modify to only throw out the stdout

[dkess]

Hmm, that's a good point, stripping stdout is probably OK here.

[fydai]

Looks fine to me, I would add a comment before the cd ~/public_html line saying that you are changing the wordpress database password.

[abizer]

please make sure to squash commits before merging them.

also, makemysql is used in more contexts than /just/ updating WordPress passwords - I don't use WordPress for example, but I do use my OCF MySQL instance for other reasons. This is nominally safe, but should probably prompt to accept before running commands against someone's WordPress install.