Jenkins fixes #20
Merged
Jenkins fixes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins uses "." for hierarchy.
Apparently the "tests" property of a "testsuite" is required: https://github.com/jenkinsci/xunit-plugin/blob/14c6e39c38408b9ed6280361484a13c6f5becca7/src/main/resources/org/jenkinsci/plugins/xunit/types/model/xsd/junit-10.xsd#L102
liskin
referenced
this pull request
Mar 9, 2017
- used for including parent group names - hence create appropriate "classname" for each "testcase". (turns out "classname" is an required field) - in additions, add type signature to the `runTest` function to help understanding the application.
haishengwu-okta
approved these changes
Mar 9, 2017
| @@ -130,11 +131,14 @@ antXMLRunner = Tasty.TestReporter optionDescription runner | |||
| Const summary <$ State.modify (+ 1) | |||
|
|
|||
| runGroup groupName children = Tasty.Traversal $ Functor.Compose $ do | |||
| Const soFar <- Reader.withReaderT (++ [groupName]) $ Functor.getCompose $ Tasty.getTraversal children | |||
| Const soFar <- Reader.local (groupName :) $ Functor.getCompose $ Tasty.getTraversal children | |||
There was a problem hiding this comment.
nit:
pre-append groupName then reverse seems a bit waist rather than append to end.
There was a problem hiding this comment.
Appending to a list is generally frowned upon for its computational complexity, but in this case it probably wouldn't be noticeable.
|
@ocharles just in case he missed.. |
|
Thanks for the reminder! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for Jenkins, see the discussion at a01df06#commitcomment-21211275