Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to ignore weeds #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add the ability to ignore weeds #58

wants to merge 2 commits into from

Conversation

ocharles
Copy link
Owner

Fixes #56

src/Weeder/Main.hs Outdated Show resolved Hide resolved
@ocharles
Copy link
Owner Author

ocharles commented Jan 7, 2021

This is currently in limbo pending support from users. I thought I needed this, turns out I don't. But maybe others do?

@EncodePanda
Copy link

I've "just" started using weeder for my personal projects, so I don't know yet :)

@shapr
Copy link

shapr commented Oct 21, 2021

Work codebase is 500kloc and we have several example projects that aren't roots and I would like to ignore.
I've set them as roots, but I could see the benefit of ignoring Example.hs and that sort of thing!

@anka-213
Copy link

Yes, this feature would be useful.

@philderbeast
Copy link
Contributor

For haskell/cabal, it might help there being able to ignore cabal-testsuite:

$ weeder --version
weeder version 2.7.0
hie version 9063
$ weeder --write-default-config
Did not find config: wrote default config to ./weeder.toml
incompatible hie file: /.../cabal-testsuite/PackageTests/CopyHie/setup.dist/work/dist/build/extra-compilation-artifacts/hie/HieLocal.hie
    this version of weeder was compiled with GHC version 9063
    the hie files in this project were generated with GHC version 9047
    weeder must be built with the same GHC version as the project it is used on

@NorfairKing
Copy link
Contributor

NorfairKing commented Apr 7, 2024

@ocharles I definitely need this for false positives such as TH splices.

In fact, the last three times I tried using weeder, I decided not to because I couldn't ignore false-positives :P
Now I figured out that you can work around this by adding false positives as roots, but then those grow weeds as well, so requiring the ignores to match something is necessary too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to ignore weeds without creating roots
6 participants