Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make cte_alias compatible with Ocient #16

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Fix: make cte_alias compatible with Ocient #16

merged 2 commits into from
Feb 8, 2023

Conversation

alexclavel-ocient
Copy link
Collaborator

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jwilliams-ocient
Copy link
Collaborator

is the formatting intentional?

@alexclavel-ocient
Copy link
Collaborator Author

is the formatting intentional?

Yes, the indentation is necessary for the code to run

@alexclavel-ocient alexclavel-ocient merged commit 75e4e35 into master Feb 8, 2023
@alexclavel-ocient alexclavel-ocient deleted the user/aclavel/DB-23276 branch February 8, 2023 17:57
@jwilliams-ocient
Copy link
Collaborator

oh shit, I think I broke this with the pre-commit PR? we need to add a unit test for fetch_data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilliams-ocient jwilliams-ocient jwilliams-ocient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexclavel-ocient @jwilliams-ocient