Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix broken unit tests #23

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Conversation

jwilliams-ocient
Copy link
Collaborator

@jwilliams-ocient jwilliams-ocient commented Apr 20, 2023

SUMMARY

Fixes the failing unit tests blocking merge. A test case was removed because it tests functionality that the OCient engine does not implement.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

========== 10 passed, 512 warnings in 8.60s ==========

TESTING INSTRUCTIONS

pytest --durations-min=0.5 --cov-report= --cov=superset  --cache-clear tests/unit_tests/db_engine_specs/test_ocient.py

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jwilliams-ocient jwilliams-ocient merged commit 787e303 into master Apr 20, 2023
40 of 50 checks passed
@jwilliams-ocient jwilliams-ocient deleted the user/jwilliams/fix-unit-tests branch April 20, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants