Feature/did spec update 1.0 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Updated comments as needed to 1.0 specific info.
…w specifies a did-url rule instead of did-reference. Param existence is also checked by IsURL().
…d to output Param array when valid.
…id-reference. Removed an unnecessary expicit typing.
… Value to be valid.
… grammar. The parser steps for param name and value are quire similar, so an additional method was extracted that handles the extraction and transition for both the param-name and param-value rules.
…ethod requiring the existence of a path or path segments.
|
@hollyfeld This is awesome. Thanks for the PR! |
|
@hollyfeld the changes look great 👍 A couple of the commit message subject lines are too long, it would be nice to amend that before a merge. Could you squash this PR into one commit? Limit the subject line to 50 chars, everything else in the body. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated did ABNF documentation.
Updated Code to handle rule changes from previous ABNF.
Updated/Added additional tests to handle rule changes/additions.
Updated code level comments.