This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
feat(tsconfig): add ability to extend base tsconfig #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjstevens
commented
Sep 29, 2020
Comment on lines
+54
to
+56
| target: tsconfigParsed.options.target === undefined ? | ||
| tsconfigParsed.options.target : | ||
| typescript.ScriptTarget[tsconfigParsed.options.target], |
There was a problem hiding this comment.
This bit is because parseJsonConfigFileContent() transforms "target" into its numerical enum value, so we have to change it back to a string to use with tsnode.register().
garrettjstevens
commented
Sep 29, 2020
Comment on lines
-104
to
-109
| const {rootDir, rootDirs, outDir} = tsconfig.compilerOptions | ||
| const rootDirPath = rootDir || (rootDirs || [])[0] | ||
| if (!rootDirPath || !outDir) return orig | ||
| const {rootDir, rootDirs, outDir: lib} = tsconfig.compilerOptions // ./lib | ||
| const src = rootDir || (rootDirs || [])[0] // ./src | ||
| if (!src || !lib) return orig | ||
| // rewrite path from ./lib/foo to ./src/foo | ||
| const lib = path.join(root, outDir) // ./lib | ||
| const src = path.join(root, rootDirPath) // ./src |
There was a problem hiding this comment.
parseJsonConfigFileContent() resolves rootDir, rootDirs, and outDir to their full paths, so no need to join their path with the root.
garrettjstevens
added a commit
to GMOD/jbrowse-components
that referenced
this pull request
Sep 29, 2020
It's not supported by oclif, but could be re-enabled if oclif/config#177 is accepted.
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 12 12
Branches 3 3
======================================
Misses 12 12 Continue to review full report at Codecov.
|
amphro
approved these changes
Sep 30, 2020
mshwery
approved these changes
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176 by using TypeScript's
parseJsonConfigFileContent(), which resolves the "extends" in a tsconfig and merges the various options in the base and extending tsconfigs.I wasn't what was a good way to add a test for having a base and extending config. Also, this is a pretty minimal change, so it could be expanded/cleaned up a bit based on your preferences.