fix: restore exit(0) behavior

oclif · Oct 27, 2023 · 0c3fdd7 · 0c3fdd7
1 parent ccfbf3d
commit 0c3fdd7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/command.ts b/src/command.ts
@@ -210,9 +210,7 @@ export abstract class Command {
     return Errors.error(input, options as any)
   }
 
-  public exit(code: number): never
-  public exit(code: 0): void
-  public exit(code = 0): void | never {
+  public exit(code = 0): never {
     Errors.exit(code)
   }
 

diff --git a/src/errors/index.ts b/src/errors/index.ts
@@ -11,10 +11,8 @@ export {ExitError} from './errors/exit'
 export {ModuleLoadError} from './errors/module-load'
 export {handle} from './handle'
 
-export function exit(code = 0) {
-  if (code !== 0) {
-    throw new ExitError(code)
-  }
+export function exit(code = 0): never {
+  throw new ExitError(code)
 }
 
 export function error(input: Error | string, options: {exit: false} & PrettyPrintableError): void

diff --git a/test/command/command.test.ts b/test/command/command.test.ts
@@ -68,7 +68,8 @@ describe('command', () => {
 
       return Command.run([])
     })
-    .it('exits with 0 does not throw error')
+    .catch(/EEXIT: 0/)
+    .it('exits with 0')
 
   describe('parse', () => {
     fancy.stdout().it('has a flag', async (ctx) => {