fix: accept integer 0 as valid arg input (#34)

oclif · Sep 9, 2020 · 36eb02f · 36eb02f
1 parent 60a3615
commit 36eb02f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/parser/validate.ts b/src/parser/validate.ts
@@ -34,7 +34,7 @@ export function validate(parse: {
       }
 
       if (arg.required) {
-        if (!parse.output.argv[index]) {
+        if (!parse.output.argv[index] && parse.output.argv[index] as any as number !== 0) {
           missingRequiredArgs.push(arg)
         }
       }

diff --git a/test/parser/validate.test.ts b/test/parser/validate.test.ts
@@ -89,15 +89,20 @@ describe('validate', () => {
           required: true,
         },
       },
-      args: [],
+      args: [
+        {
+          name: 'zero',
+          required: true,
+        },
+      ],
       strict: true,
       context: {},
       '--': true,
     }
 
     const output = {
-      args: {},
-      argv: [],
+      args: {zero: 0},
+      argv: [0],
       flags: {int: 0},
       raw: [],
       metadata: {