Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript 4.8 complains *.d.ts #482

Closed
riywo opened this issue Aug 30, 2022 · 2 comments · Fixed by #493
Closed

TypeScript 4.8 complains *.d.ts #482

riywo opened this issue Aug 30, 2022 · 2 comments · Fixed by #493
Labels
bug Something isn't working

Comments

@riywo
Copy link

riywo commented Aug 30, 2022 •
edited

Describe the bug
Once we bump our typescript version from 4.7.4 to 4.8.2, @oclif/core start failing to compile: autifyhq/autify-cli#84

    > @autifyhq/autify-cli@0.8.0-beta.0 build
    > shx rm -rf dist && tsc -b

    node_modules/@oclif/core/lib/command.d.ts(100,35): error TS2344: Type 'F' 
    does not satisfy the constraint 'FlagOutput'.
    node_modules/@oclif/core/lib/command.d.ts(100,92): error TS2344: Type 'F' 
    does not satisfy the constraint 'OutputFlags<any>'.
    node_modules/@oclif/core/lib/parser/index.d.ts(9,35): error TS2344: Type 
    'TFlags' does not satisfy the constraint 'FlagOutput'.
    node_modules/@oclif/core/lib/parser/index.d.ts(9,74): error TS2344: Type 
    'TFlags' does not satisfy the constraint 'OutputFlags<any>'.

    Code: 1

To Reproduce
Steps to reproduce the behavior:

  1. Pull the dependabot branch from Bump typescript from 4.7.4 to 4.8.2 autifyhq/autify-cli#84
  2. npm run build

Expected behavior
No failure on tsc.

Screenshots
N/A

Environment (please complete the following information):
ubuntu-latest and macos-latest of GitHub Actions hosted runners. @oclif/core is updated to the latest (1.16.0) autifyhq/autify-cli#85

Additional context
Originally this issue was reported by #480 but closed by the author. Hence, this one.
@akash1810 akash1810 mentioned this issue Aug 31, 2022
Closed
Frederick888 added a commit to zendesk/zcli that referenced this issue Sep 8, 2022
@Frederick888
Pin TypeScript to <4.8 to avoid oclif/core error
ce8e79a 
See [1]. oclif/core doesn't transpile using TypeScript 4.8 at the
moment.

[1] oclif/core#482
@Frederick888 Frederick888 mentioned this issue Sep 8, 2022
Closed
1 task
Frederick888 added a commit to zendesk/zcli that referenced this issue Sep 13, 2022
@Frederick888
Pin TypeScript to <4.8 to avoid oclif/core error
8310a7b 
See [1]. oclif/core doesn't transpile using TypeScript 4.8 at the
moment.

[1] oclif/core#482
Frederick888 added a commit to zendesk/zcli that referenced this issue Sep 13, 2022
@Frederick888
fix: Pin TypeScript to <4.8 to avoid oclif/core error
0a7a2bb 
See [1]. oclif/core doesn't transpile using TypeScript 4.8 at the
moment.

[1] oclif/core#482
@Frederick888 Frederick888 mentioned this issue Sep 13, 2022
Merged
1 task
@mdonnalley mdonnalley added the bug Something isn't working label Sep 14, 2022
@git2gus
Copy link

git2gus bot commented Sep 14, 2022

This issue has been linked to a new work item: W-11757550

@mdonnalley mdonnalley mentioned this issue Sep 14, 2022
Merged
@riywo riywo mentioned this issue Sep 15, 2022
Closed
@riywo
Copy link
Author

riywo commented Sep 27, 2022

Thank you for the fix. We were able to merge Tyepescript 4.8 autifyhq/autify-cli#115, just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: work with 4.8.3 oclif/core
2 participants
@riywo @mdonnalley