Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global flags #101

Closed
wants to merge 10 commits into from
Closed

feat: add global flags #101

wants to merge 10 commits into from

Conversation

RasPhilCo
Copy link
Contributor

WIP

requires #94 #99

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #101 (0b9c05c) into master (4b44270) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #101   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines          15      15           
  Branches        2       2           
======================================
  Misses         15      15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b44270...0b9c05c. Read the comment docs.

@RodEsp
Copy link
Contributor

RodEsp commented Aug 5, 2021

I believe this functionality has already been added with the addition of the --json global flag:

core/src/command.ts

Lines 115 to 120 in 11cbd6b

private static globalFlags = {
json: Flags.boolean({
description: 'Format output as json.',
helpGroup: 'GLOBAL',
}),
}

Do we still need this PR for anything or should we close it @RasPhilCo?

@RasPhilCo RasPhilCo closed this Sep 20, 2021
@RasPhilCo RasPhilCo deleted the global-flags branch September 20, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants