Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no more template repos #1395

Merged
merged 5 commits into from
May 1, 2024
Merged

feat: no more template repos #1395

merged 5 commits into from
May 1, 2024

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Apr 30, 2024

Use ejs templates instead of using the hello-world and hello-world-esm template repos

Windows + pnpm tests are failing because of issue with running npm install on node 22. See nodejs/node#52682

@W-15491712@

mshanemc
mshanemc previously approved these changes May 1, 2024
Copy link
Member

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as is.

one suggestion in PR form. #1397

@@ -1,12 +1,13 @@
/* eslint-disable unicorn/no-await-expression-member */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this rule at all. () are way nicer than keeping a 2nd variable around to avoid it.

I'd be in favor of turning it off oclif-wide!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshanemc
Copy link
Member

mshanemc commented May 1, 2024

QA:

created from outside the oclif repo using ../oclif/oclif/bin/run.js generate testCli1
✅ hello world runs
✅ stuff looks right (pjson, readme, etc)
✅ readme has plugin-plugin in it, so testCli1/bin/run.js plugins install @salesforce/plugin-settings . It installs!
testCli1/bin/run.js config list [that actually works!]

create an ESM plugin using all the flags
../oclif/oclif/bin/run.js generate testCli2 --author mshanemc --description "A Plugin" --module-type ESM --name test-cli-2 --owner oclif --package-manager yarn --repository test-cli-2 --license ToKill --bin testCli2
✅ builds a CLI without prompting me
✅ hello world runs
✅ stuff looks right (pjson, readme, etc) [type: module]
✅ install @salesforce/plugin-settings. It installs! ✅testCli2/bin/run.js` config list

@mshanemc mshanemc merged commit ddab537 into main May 1, 2024
50 of 54 checks passed
@mshanemc mshanemc deleted the mdonnalley/no-clone branch May 1, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants