-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: no more template repos #1395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved as is.
one suggestion in PR form. #1397
@@ -1,12 +1,13 @@ | |||
/* eslint-disable unicorn/no-await-expression-member */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this rule at all. ()
are way nicer than keeping a 2nd variable around to avoid it.
I'd be in favor of turning it off oclif-wide!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA: created from outside the oclif repo using create an ESM plugin using all the flags |
Use ejs templates instead of using the hello-world and hello-world-esm template repos
Windows + pnpm tests are failing because of issue with running
npm install
on node 22. See nodejs/node#52682@W-15491712@