fix: edge cases for integers flags

[tbrannam]

validateFlags was not differentiating between 0 and undefined which prevented 0 from being accepted as an input for integer based flags.

integer did not include optional leading - preventing negative numbers from being accepted

[salesforce-cla]

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Todd Brannam <t***@h***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

[codecov]

Codecov Report

Merging #50 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   91.18%   91.35%   +0.17%     
==========================================
  Files          11       11              
  Lines         329      324       -5     
  Branches       89       85       -4     
==========================================
- Hits          300      296       -4     
+ Misses         13       12       -1     
  Partials       16       16

Impacted Files	Coverage Δ
src/validate.ts	96.87% <100%> (+2.28%)	⬆️
src/flags.ts	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265a73f...ca11405. Read the comment docs.

[keawade]

Oh man, I opened #51 just a few hours after this! 😆I didn't see anything in the issues and didn't think to check the PRs, sorry!

Could you add the additional tests I wrote to verify negative numbers and known failure cases (fractions and decimals) to this PR? Then I can close my PR.

[tbrannam]

Sure thing. Will update my pr

…

________________________________ From: Keith Wade <notifications@github.com> Sent: Tuesday, May 7, 2019 11:31:25 AM To: oclif/parser Cc: Todd Brannam; Author Subject: Re: [oclif/parser] Fix edge cases for integers flags (#50) Oh man, I opened #51<#51> just a few hours after this! 😆I didn't see anything in the issues and didn't think to check the PRs, sorry! Could you add the additional tests<https://github.com/oclif/parser/pull/51/files#diff-bb3e4eab90bca733bbd7a819227ba863R331> I wrote to verify negative numbers and known failure cases (fractions and decimals) to this PR? Then I can close my PR. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#50 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAATHXNGQ7FVAYO6ESZRSDDPUGOE3ANCNFSM4HKUD4FA>.

[tbrannam]

@keawade added your tests in

[keawade]

@jdxcode, can we get a review please? 😄

[keawade]

Looks good to me!

[tbrannam]

@jdxcode seems to have left Heroku, are you still caring for this baby?

[keawade]

@mattgraham maybe? He's the only publicly listed member of the oclif org.

[jdx]

I'm no longer working on this project. @RasPhilCo and @elbandito should be able to assist

[RasPhilCo]

Good fix! 🏄