Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix: make EnumFlagOptions#options of type T[] instead of string #69

Merged
merged 2 commits into from
May 15, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Feb 10, 2020

Fixes #67

Sadly the type still isn't inferable, but at least now we can pass it in explicitly.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #69   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines          29      29           
  Branches       14      14           
======================================
  Misses         29      29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4486e6...715af23. Read the comment docs.

@G-Rath
Copy link
Contributor Author

G-Rath commented Feb 10, 2020

@codecov no it won't - you're comparing against the wrong thing :)

Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

@RasPhilCo RasPhilCo merged commit 2fefccb into oclif:master May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum flags can be incorrectly typed
2 participants