Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(topics): avoid recomputing topics in loop #189

Merged
merged 1 commit into from
Feb 3, 2021
Merged

perf(topics): avoid recomputing topics in loop #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,12 @@ export default class Help extends HelpBase {
* and this can be removed.
*/
private get _topics(): Config.Topic[] {
return this.config.topics.filter((topic: Config.Topic) => {
// since this.config.topics is a getter that does non-trivial work, cache it outside the filter loop for
// performance benefits in the presence of large numbers of topics
const topics = this.config.topics
return topics.filter((topic: Config.Topic) => {
// it is assumed a topic has a child if it has children
const hasChild = this.config.topics.some(subTopic => subTopic.name.includes(`${topic.name}:`))
const hasChild = topics.some(subTopic => subTopic.name.includes(`${topic.name}:`))
return hasChild
})
}
Expand Down