Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow templates in usage and provide command context #35

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

amphro
Copy link
Contributor

@amphro amphro commented Jan 30, 2019

When writing custom usage strings, it would be nice to still include the command name, but there is no way to currently do that. This PR provides a way to template usage strings and provides the command as an variable to template.

@amphro amphro requested a review from jdx January 30, 2019 01:31
@amphro
Copy link
Contributor Author

amphro commented Jan 30, 2019

I can redo this PR to not change method signatures. However it seems to make sense to just have command on this and I don't think anything builds on top of plugin-help. Also, I renamed the command method to generate which seams more appropriate but really it is to allow the command property.

Copy link
Contributor

@jdx jdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jdx jdx merged commit 2dc9533 into master Jan 30, 2019
@jdx jdx deleted the usagetemplates branch January 30, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants