feat: support spaced commands #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/hooks/not-found.test.ts
Outdated
| @@ -17,6 +17,17 @@ describe('command_not_found', () => { | |||
| expect(ctx.stdout).to.be.contain('commands\nhelp') | |||
| }) | |||
|
|
|||
| test | |||
| .only() | |||
There was a problem hiding this comment.
looks like a leftover .only ... not super familiar with OCLIF but lgtm
mdonnalley
force-pushed
the
mdonnalley/spaced-commands
branch
from
404d4b1
to
6437d30
Compare
RodEsp
approved these changes
Apr 9, 2021
amphro
reviewed
Apr 14, 2021
| }, | ||
| "engines": { | ||
| "node": ">=8.0.0" | ||
| "node": ">=14.0.0" |
There was a problem hiding this comment.
I'm starting to second guess this. Since node 12 is still a LTS until mid-2022, I wonder if it is a good move to require 14. I guess another way to ask this, is it ok the unified CLI requires node 14? Maybe that is... we can also see what kind of reaction we get when we do the announcement post.
.circleci/config.yml
Outdated
| - release: | ||
| context: org-global | ||
| filters: | ||
| branches: {only: master} | ||
| branches: {only: main} |
There was a problem hiding this comment.
I'm guessing we aren't merging any of these PRs until we have an @oclif/core@v1?
mdonnalley
force-pushed
the
mdonnalley/spaced-commands
branch
from
b90032c
to
aea5dd7
Compare
mdonnalley
added a commit
that referenced
this pull request
Jun 7, 2021
* feat: support spaced commands * fix: do not suggest hidden commands * chore: prepare for v2 * chore: update core * chore: update circle config * chore: remove github actions * chore: regenerate lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for spaced commands
Depends on oclif/core#143
Fixes #28