You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#517 Introduced calling tsc on plugins that have typescript as a dev dependency, however this fails when the module is installed from NPM and is already compiled (excluding it's source typescript). I am very confused why checking if typescript is a dependency is the criteria used to determine if tsc should be executed on a module, and do not think that you should be trying to compile these modules. If it must be done, you could at least check if there is a tsconfig and typescript files in the module folder? You do not even know if Typescript is being used by checking if it is in a dev dependency, tsc/typescript could be coming from a package of dev tools like https://github.com/spotify/web-scripts or similar. This change has broken some CI that I own and is proving to be rather annoying to fix effectively.
#517 Introduced calling
tsc
on plugins that have typescript as a dev dependency, however this fails when the module is installed from NPM and is already compiled (excluding it's source typescript). I am very confused why checking if typescript is a dependency is the criteria used to determine if tsc should be executed on a module, and do not think that you should be trying to compile these modules. If it must be done, you could at least check if there is a tsconfig and typescript files in the module folder? You do not even know if Typescript is being used by checking if it is in a dev dependency, tsc/typescript could be coming from a package of dev tools like https://github.com/spotify/web-scripts or similar. This change has broken some CI that I own and is proving to be rather annoying to fix effectively.How to reproduce:
The text was updated successfully, but these errors were encountered: