Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking broken after compiling modules that have Typescript dev dependency #559

Closed
Daniel-Webster opened this issue Mar 3, 2023 · 1 comment · Fixed by #564
Closed

Comments

@Daniel-Webster
Copy link

Daniel-Webster commented Mar 3, 2023

#517 Introduced calling tsc on plugins that have typescript as a dev dependency, however this fails when the module is installed from NPM and is already compiled (excluding it's source typescript). I am very confused why checking if typescript is a dependency is the criteria used to determine if tsc should be executed on a module, and do not think that you should be trying to compile these modules. If it must be done, you could at least check if there is a tsconfig and typescript files in the module folder? You do not even know if Typescript is being used by checking if it is in a dev dependency, tsc/typescript could be coming from a package of dev tools like https://github.com/spotify/web-scripts or similar. This change has broken some CI that I own and is proving to be rather annoying to fix effectively.

How to reproduce:

yarn add --dev sfdx-cli sfdmu 
yarn sfdx plugins:link ./node_modules/sfdmu 
yarn run v1.22.17
$ /Users/klink/Tingle/sfdx-action-container/node_modules/.bin/sfdx plugins:link ./node_modules/sfdmu
sfdx-cli: linking plugin sfdmu... ⣻
sfdx-cli: linking plugin sfdmu... !
    Error: yarn run tsc -p . --incremental --skipLibCheck exited with code 1
error Command failed with exit code 1.
@git2gus
Copy link

git2gus bot commented Mar 7, 2023

This issue has been linked to a new work item: W-12652231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants