Appended the suppression of unused local variables using RAII #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2015 00:54
…in RAII manner This protect the false positives about some basic classes such as std::lock_guard Some additional checks should be appended, to ensure that the given configuration is valid
| if (!isUnusedLocalVariable(varDecl)) | ||
| { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Indentations for above two lines.
|
Again, liked the code changes a lot. Thanks for the work. Let's add tests before merging them. |
|
Merged this with some test changes as well. Thank you, @Hinterwaeldlers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes allow to suppress the complains about unused variables.
When using RAII such as std::lock_guard the intention of do not access the variable further is intended
There are two variables, which allow to change the baviour:
RAII_DEFAULT_CLASSES which suppress std::lock_guard and std::unique_lock
RAII_CUSTOM_CLASSES to allow the user to define further own created parts
At the moment there are no tests appended and maybe further classes should be appended to the default definition