fix: files cache should be cleaned upon resolution of the promise

Fixes #189
ocombe · May 29, 2015 · 9a186c9 · 9a186c9
1 parent 3159547
commit 9a186c9
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 7 deletions.
diff --git a/dist/modules/ocLazyLoad.loaders.common.js b/dist/modules/ocLazyLoad.loaders.common.js
@@ -51,6 +51,7 @@
                         el.src = params.cache === false ? cacheBuster(path) : path;
                         break;
                     default:
+                        filesCache.remove(path);
                         deferred.reject(new Error("Requested type \"" + type + "\" is not known. Could not inject \"" + path + "\""));
                         break;
                 }
@@ -59,9 +60,11 @@
                     el.onload = el.onreadystatechange = null;
                     loaded = 1;
                     $delegate._broadcast("ocLazyLoad.fileLoaded", path);
+                    filesCache.remove(path);
                     deferred.resolve();
                 };
                 el.onerror = function () {
+                    filesCache.remove(path);
                     deferred.reject(new Error("Unable to load " + path));
                 };
                 el.async = params.serie ? 0 : 1;

diff --git a/dist/ocLazyLoad.js b/dist/ocLazyLoad.js
diff --git a/dist/ocLazyLoad.js.map b/dist/ocLazyLoad.js.map
diff --git a/dist/ocLazyLoad.min.js b/dist/ocLazyLoad.min.js
diff --git a/dist/ocLazyLoad.min.js.map b/dist/ocLazyLoad.min.js.map
diff --git a/dist/ocLazyLoad.require.js b/dist/ocLazyLoad.require.js
diff --git a/dist/ocLazyLoad.require.js.map b/dist/ocLazyLoad.require.js.map
diff --git a/dist/ocLazyLoad.require.min.js b/dist/ocLazyLoad.require.min.js
diff --git a/dist/ocLazyLoad.require.min.js.map b/dist/ocLazyLoad.require.min.js.map
diff --git a/src/ocLazyLoad.loaders.common.js b/src/ocLazyLoad.loaders.common.js
@@ -51,17 +51,20 @@
                         el.src = params.cache === false ? cacheBuster(path) : path;
                         break;
                     default:
-                    deferred.reject(new Error(`Requested type "${ type }" is not known. Could not inject "${ path }"`));
+                        filesCache.remove(path);
+                        deferred.reject(new Error(`Requested type "${ type }" is not known. Could not inject "${ path }"`));
                         break;
                 }
                 el.onload = el['onreadystatechange'] = function(e) {
                     if((el['readyState'] && !/^c|loade/.test(el['readyState'])) || loaded) return;
                     el.onload = el['onreadystatechange'] = null;
                     loaded = 1;
                     $delegate._broadcast('ocLazyLoad.fileLoaded', path);
+                    filesCache.remove(path);
                     deferred.resolve();
                 };
                 el.onerror = function() {
+                    filesCache.remove(path);
                     deferred.reject(new Error(`Unable to load ${ path }`));
                 };
                 el.async = params.serie ? 0 : 1;