Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version on Lazy loaded file #137

Closed
dud3 opened this issue Mar 8, 2015 · 9 comments
Closed

Version on Lazy loaded file #137

dud3 opened this issue Mar 8, 2015 · 9 comments

Comments

@dud3
Copy link

dud3 commented Mar 8, 2015

I have the following:

<div oc-lazy-load="{ name: 'app.submission', files: [ '/src/app/controllers/submissionCtrl.js?v=xy12' , '/src/app/factories/categoriesSvc.js' ] }">

The one with the version on '/src/app/controllers/submissionCtrl.js?v=xy12' doesn't load ?

Thank you in advance.

Hopefully I'm not asking a silly question.

cc @ocombe

@ocombe
Copy link
Owner

ocombe commented Mar 8, 2015

Hmm I don't know why no one ever reported this before, but the file type detection regexes don't take into account the file names with parameters at the end ("?v=xy12" in this case).
I'll fix it, in the mean time you can use:

<div oc-lazy-load="{[ {path: '/src/app/controllers/submissionCtrl.js?v=xy12', type: 'js'} , '/src/app/factories/categoriesSvc.js' ]">

By the way, with ocLazyLoad 0.6.x you don't need to give the name of the module that you're lazyloading

@ocombe ocombe added the bug label Mar 8, 2015
@ocombe ocombe added this to the 1.0 - Stable api & modularity milestone Mar 8, 2015
@ocombe ocombe closed this as completed in 57e1801 Mar 8, 2015
@ocombe
Copy link
Owner

ocombe commented Mar 8, 2015

Thanks for the report, this is fixed!

@dud3
Copy link
Author

dud3 commented Mar 8, 2015

+1.

@dud3
Copy link
Author

dud3 commented Mar 8, 2015

Another quick question, did we happen to update the bower's file ?

@ocombe
Copy link
Owner

ocombe commented Mar 8, 2015

nop I didn't make a new release yet

@ocombe
Copy link
Owner

ocombe commented Mar 9, 2015

I've released 0.6.3 with this fix :)

@dud3
Copy link
Author

dud3 commented Mar 9, 2015

Awesome, well thanks a lot :D>.

@ocombe
Copy link
Owner

ocombe commented Mar 9, 2015

No problem! I wanted to see if new bugs from the 0.6.x release would pop up so that I can put more fixes in this new release, but it looks stable now.
I've started working on the big refactoring for 1.0 now :)

@dud3
Copy link
Author

dud3 commented Mar 9, 2015

That sounds even more awesome, looking forward to the big release :D>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants