-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version on Lazy loaded file #137
Comments
Hmm I don't know why no one ever reported this before, but the file type detection regexes don't take into account the file names with parameters at the end ("?v=xy12" in this case). <div oc-lazy-load="{[ {path: '/src/app/controllers/submissionCtrl.js?v=xy12', type: 'js'} , '/src/app/factories/categoriesSvc.js' ]"> By the way, with ocLazyLoad 0.6.x you don't need to give the name of the module that you're lazyloading |
Thanks for the report, this is fixed! |
+1. |
Another quick question, did we happen to update the bower's file ? |
nop I didn't make a new release yet |
I've released 0.6.3 with this fix :) |
Awesome, well thanks a lot :D>. |
No problem! I wanted to see if new bugs from the 0.6.x release would pop up so that I can put more fixes in this new release, but it looks stable now. |
That sounds even more awesome, looking forward to the big release :D>. |
I have the following:
The one with the version on
'/src/app/controllers/submissionCtrl.js?v=xy12'
doesn't load ?Thank you in advance.
Hopefully I'm not asking a silly question.
cc @ocombe
The text was updated successfully, but these errors were encountered: