duplicate css, js

[pruge]

ui-router
when access /components/:id , add css,js file every time

        .state('components', {
            url: '/components/:id',
            resolve: {
                load: ['$ocLazyLoad','$stateParams', function ($ocLazyLoad, stateParams) {
                    return $ocLazyLoad.load({
                        name: stateParams.id,
                        files: ['some.css', 'some.js']
                    })
                }] 
            },
            templateUrl: 'some.html'
        })

$script prevent duplicate call same js not css

$ocLazyLoadProvider.config({ asyncLoader: $script }); 

I add some code to prevent duplicate css

                var checkCssArr = [];
                cssLoader = cssLoader || function(paths, callback) {
                    if (!_.contains(checkCssArr, paths[0])) {
                        checkCssArr.push(paths[0]);
                    } else {
                        paths = [];
                    }
                    var promises = [];
                    angular.forEach(paths, function loading(path) {
                        promises.push(buildElement('css', path));
                    });
                    $q.all(promises).then(function success() {
                        callback();
                    }, function error(err) {
                        callback(err);
                    });
                }

this method is not accepted jsLoader.

How can I prevent duplicate js, css?

[ocombe]

You're right I should add something to prevent multiple insertions / downloads in the native loaders.
I have an idea for that, I'll code it asap, thanks for the suggestion.

[taz]

Hi,

The original PR for css loading I did back on May 10 had duplicate protection baked into the buildElement function :-)

f9dc860

It was just a fairly simplistic approach to track loaded paths...

[ocombe]

Feature added in 0.3.1 :)

[pruge]

ocLazyLoad 0.3.1 update, but still duplicate loading js/css

[ocombe]

Do you use the native loaders ?

[pruge]

yes

[taz]

Sorry, had to revert and recommit as github thought I'd replaced the entire file. It made it very difficult to see what I'd actually changed.

Three small changes, one of which should fix the duplicate load issue.

I'll do a PR for it when I've tested it a little more. I need to revisit the last change again in particular as I've had it sitting there locally since 0.2.0 and the whole loading methodology looks to have changed a little bit since I wrote it. I think it's still ok though.

B.

EDIT: Hold that thought, I had another look and I don't think I've accounted for the OP's original scenario. I'll have another look tomorrow if I get a chance. Feel free to test etc in the meantime though. Need sleep!

[ocombe]

Oh nice catch, I didn't think of those use cases !

[ocombe]

Any news on this PR @BenBlazely ?

[taz]

PR submitted. I actually thought I'd already submitted it on the weekend... A busy week + a baby with a cold/flu = the memory of a goldfish. :-)

Good thing I hadn't as I found a couple of small issues and have fixed them.