Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use variable pull_secret_file for local registry #186

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

yussufsh
Copy link
Contributor

Fixes #180

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

Fixes ocp-power-automation#180

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh yussufsh added the backport Need to port the changes to other branches label Mar 15, 2021
@yussufsh
Copy link
Contributor Author

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yussufsh
Copy link
Contributor Author

/cc @cs-zhang

@ltccci ltccci requested a review from cs-zhang March 17, 2021 05:21
Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Mar 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, cs-zhang, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cs-zhang cs-zhang merged commit bd4ce38 into ocp-power-automation:release-4.5 Mar 17, 2021
@yussufsh yussufsh deleted the release-4.5 branch February 3, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved backport Need to port the changes to other branches lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants