Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout added while removing worker node #204

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

yussufsh
Copy link
Contributor

Added 3 min wait for the drain command to complete. This will help when no worker nodes are left for scheduling non disruptive pods.

Fixes #203

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

Added 3 min wait for the drain command to complete. This will help when no worker nodes are left for scheduling non disruptive pods.

Fixes ocp-power-automation#203

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @bpradipt @cs-zhang

Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ltccci
Copy link
Contributor

ltccci commented Apr 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cs-zhang, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit ae419af into ocp-power-automation:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform destroy fails when evicting pods error out as no workers left
4 participants