Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To set mtu on private network #229

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

aishwaryabk
Copy link
Collaborator

Signed-off-by: Aishwarya Kamat aishwarya.kamat@ibm.com

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add it in var.tfvars?

modules/5_install/install.tf Outdated Show resolved Hide resolved
@aishwaryabk
Copy link
Collaborator Author

Could you also add it in var.tfvars?

@yussufsh I have added "private_network_mtu" to the var.tfvars file.

@yussufsh
Copy link
Contributor

@aishwaryabk Please help with the conflicts.

Signed-off-by: Aishwarya Kamat <aishwarya.kamat@ibm.com>
@aishwaryabk
Copy link
Collaborator Author

@aishwaryabk Please help with the conflicts.

@yussufsh The conflicts are resolved.

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aishwaryabk, cs-zhang, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cs-zhang cs-zhang merged commit d445957 into ocp-power-automation:master Feb 9, 2022
@aishwaryabk aishwaryabk deleted the new-mtu branch March 31, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants