-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LUKS encryption for OCP4 #259
Add support for LUKS encryption for OCP4 #259
Conversation
Welcome @gauravpbankar! It looks like this is your first PR to ocp-power-automation/ocp4-upi-powervm 🎉 |
Hi @gauravpbankar. Thanks for your PR. I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Similarly we raised PR related to PowerVS and it got merged. Link fot he same: |
/cc @yussufsh |
/ok-to-test |
@gauravpbankar you say you have executed and given the results. But the code is failing to validate itself. Not sure if I can trust the results given. |
After adding required changes all tests
@yussufsh Yes we have tested with all required changes but for raising PR we have used new repo and it has missed in that repo, but now we are going to take this commit and again test with required changes and will share result here then you can review it. We will update you once the deployment is completed with required changes. |
We have tested it succesfully can you please look into it: 1.luks-enabled
b. verify
2.luks-disabled
b. verify
|
@yussufsh thank you for alerting me. I've sent you a message on the side and I'll work on improving the software engineering and code hygiene. |
@gauravpbankar For Your Action
It shows that the file has a formatting violation.
Note, I did check
Execute Step 2... It needs to have proper formatting. I'm currently running through QA tests. |
Signed-off-by: Gaurav Bankar <Gaurav.Bankar@ibm.com>
Mea culpa... Gaurav had the changes on two branches. I was on the I am continuing the QE |
I've run through the QE
TF_LOG=debug terraform apply -no-color -var-file=data/var.tfvars -auto-approve -parallelism=2 2>&1 | tee t-apply-no-luks.log I checked the node status and it is correct. $ sudo cryptsetup status root The destroy command also worked as expected.
I configured the
TF_LOG=debug terraform apply -no-color -var-file=data/var.tfvars -auto-approve -parallelism=2 2>&1 | tee t-apply-no-luks.log I checked the node crypto status and it is correct.
The destroy command also worked as expected. |
Thanks @prb112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
thanks @prb112 for the confirmation.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravpbankar, Prajyot-Parab, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This feature enables LUKS encryption variables and updates the install modules to setup LUKS variables. The MachineConfig is automatically used as part of the ocp4-playbooks when LUKS is enabled.
The e2e tests we have completed are - apply, verify luks status, destroy with and without luks enabled.
Please find attached a sample result from the execution:
1.luks-enabled
a. apply
b.verify
c. destroy completed successfully
2.luks-disabled
a. apply
Apply complete! Resources: 4 added, 0 changed, 1 destroyed.
Outputs:
b. verify
Masters:
Workers:
c. destroy completed successfully
Note, we discussed updating install_playbook_tag to a new default for testing. I have left this the same as the origin. Please let me know if you want me to update the tag.
Signed-off-by: Gaurav Bankar Gaurav.Bankar@ibm.com