Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCTOPUS-612: Updates variables.tf to use correct nfs-client-provisioner Image #280

Merged
merged 1 commit into from
Feb 15, 2024
Merged

OCTOPUS-612: Updates variables.tf to use correct nfs-client-provisioner Image #280

merged 1 commit into from
Feb 15, 2024

Conversation

Chandan-Abhyankar
Copy link
Contributor

OCTOPUS-612: Changes are made so that by default nfs-client-provisioner image is "registry.k8s.io/sig-storage/nfs-subdir-external-provisioner:v4.0.2"

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chandan-Abhyankar
Once this PR has been reviewed and has the lgtm label, please assign cs-zhang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot
Copy link
Contributor

ppc64le-cloud-bot commented Feb 12, 2024 •
edited
Loading

@Chandan-Abhyankar: PR is not mergeable.

The PR state is: BLOCKED

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Chandan-Abhyankar
OCTOPUS-612: Updates variables.tf to use correct nfs-client-provision…
783b5f2 
…er image

OCTOPUS-612: Changes are made so that by default nfs-client-provisioner image is "registry.k8s.io/sig-storage/nfs-subdir-external-provisioner:v4.0.2"
Signed-off-by: Chandan Abhyankar <chandan.abhyankar@gmail.com>
Prajyot-Parab
Prajyot-Parab approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

yussufsh
yussufsh approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yussufsh
Copy link
Contributor

/meow
@Rajalakshmi-Girish

@yussufsh yussufsh merged commit 838c195 into ocp-power-automation:main Feb 15, 2024
4 of 5 checks passed
@Rajalakshmi-Girish
Copy link

/meow

@ppc64le-cloud-bot
Copy link
Contributor

@Rajalakshmi-Girish: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rajalakshmi-Girish
Copy link

/meow @Rajalakshmi-Girish

There was an issue yesterday with triggers reaching hook.
It is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@aishwaryabk aishwaryabk Awaiting requested review from aishwaryabk

@sajauddin sajauddin Awaiting requested review from sajauddin

Assignees
No one assigned
Labels
do-not-merge/non-mergeable size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chandan-Abhyankar @ppc64le-cloud-bot @yussufsh @Rajalakshmi-Girish @Prajyot-Parab