Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation and type check on variables #935 #133

Merged
merged 1 commit into from
Dec 9, 2020
Merged

validation and type check on variables #935 #133

merged 1 commit into from
Dec 9, 2020

Conversation

Elayaraja-Dhanapal
Copy link
Contributor

@Elayaraja-Dhanapal Elayaraja-Dhanapal commented Oct 27, 2020 •
edited
Loading

Terraform validation (fewer variables) and type constraints (all variables) added.

@ltccci ltccci added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2020
yussufsh
yussufsh requested changes Oct 28, 2020
View reviewed changes
modules/1_prepare/variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
Prajyot-Parab
Prajyot-Parab reviewed Oct 28, 2020
View reviewed changes
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
@ltccci ltccci added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2020
yussufsh
yussufsh reviewed Oct 30, 2020
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
Elayaraja-Dhanapal
Elayaraja-Dhanapal commented Oct 30, 2020
View reviewed changes
Copy link
Contributor Author

@Elayaraja-Dhanapal Elayaraja-Dhanapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated string lower check and word correction.

@ltccci ltccci added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2020
yussufsh
yussufsh reviewed Nov 19, 2020
View reviewed changes
variables.tf Show resolved Hide resolved
@bpradipt
Copy link
Contributor

@Elayaraja-Dhanapal can you please address the comments and rebase the PR. Would like to close this asap.

@Elayaraja-Dhanapal
Copy link
Contributor Author

rebase/merge (769ed62) contains all the changes. @yussufsh @Prajyot-Parab please validate.

@bpradipt
Copy link
Contributor

@Elayaraja-Dhanapal please also squash the multiple commits into a single one

@Elayaraja-Dhanapal
Copy link
Contributor Author

@yussufsh @Prajyot-Parab could you please validate the pull request. Thanks!

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@ltccci ltccci removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@Elayaraja-Dhanapal
Copy link
Contributor Author

@yussufsh @Prajyot-Parab Please review.

@yussufsh
Copy link
Contributor

yussufsh commented Dec 8, 2020

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@yussufsh
Copy link
Contributor

yussufsh commented Dec 8, 2020

/retest

yussufsh
yussufsh previously approved these changes Dec 8, 2020
View reviewed changes
Prajyot-Parab
Prajyot-Parab reviewed Dec 8, 2020
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bpradipt
Copy link
Contributor

bpradipt commented Dec 8, 2020

@Elayaraja-Dhanapal this needs a rebase again..

@ltccci ltccci removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@elayarajadhanapal @Elayaraja-Dhanapal
Validation and type constraint checks
0ae20b2 
Signed-off-by: Elayaraja Dhanapal <eldhanap@in.ibm.com>
@Elayaraja-Dhanapal
Copy link
Contributor Author

Done. Please review. Thanks. @yussufsh @Prajyot-Parab

yussufsh
yussufsh approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@Prajyot-Parab
Copy link
Collaborator

lgtm!

@bpradipt
Copy link
Contributor

bpradipt commented Dec 9, 2020

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Dec 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Elayaraja-Dhanapal, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit 356634b into ocp-power-automation:master Dec 9, 2020
@yussufsh yussufsh mentioned this pull request Dec 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

@yussufsh yussufsh yussufsh approved these changes

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

@bpradipt bpradipt

@yussufsh yussufsh

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Elayaraja-Dhanapal @bpradipt @Prajyot-Parab @yussufsh @ltccci @elayarajadhanapal