Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the local registry image with the official multi-arch registry image #518

Conversation

Sachin-Itagi
Copy link
Contributor

Fixes an issue where the image mirrored had a different digest and was causing a Manifest does not match provided manifest digest error when pulled using SHA value.

The PR replaces the old docker.io/ibmcom/registry-ppc64le:2.6.2.5 image with the official multi-arch image docker.io/library/registry:2

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @Sachin-Itagi! It looks like this is your first PR to ocp-power-automation/ocp4-upi-powervs 🎉

@ppc64le-cloud-bot ppc64le-cloud-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2024
@ppc64le-cloud-bot
Copy link
Contributor

Hi @Sachin-Itagi. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yussufsh
Copy link
Contributor

@Sachin-Itagi could you please create an issue first describing the problem?

@Sachin-Itagi
Copy link
Contributor Author

@yussufsh Have created an issue #519 and shared the details and the resolution.

@yussufsh
Copy link
Contributor

@Sachin-Itagi please fix the DCO error.

…y image

Signed-off-by: Sachin Itagi <sachin.itagi@ibm.com>
@Sachin-Itagi
Copy link
Contributor Author

@yussufsh Fixed the DCO issue.

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sachin-Itagi, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2024
@yussufsh yussufsh removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 22, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit cb8c818 into ocp-power-automation:main Feb 22, 2024
4 of 5 checks passed
@Sachin-Itagi Sachin-Itagi deleted the replaceLocalRegistryImage branch February 23, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Pull with SHA value from Local Registry is failing for some images.
3 participants