Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding bastion storage pool #521

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Allow overriding bastion storage pool #521

merged 1 commit into from
Mar 8, 2024

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented Feb 21, 2024 •
edited

Fixes #520

@yussufsh yussufsh marked this pull request as draft February 21, 2024 13:17
@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/non-mergeable labels Feb 21, 2024
@yussufsh yussufsh marked this pull request as ready for review February 21, 2024 13:19
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2024
@yussufsh yussufsh marked this pull request as draft February 21, 2024 13:22
@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2024
@yussufsh
Copy link
Contributor Author

/retest

@yussufsh yussufsh marked this pull request as ready for review March 8, 2024 14:33
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
@yussufsh
Copy link
Contributor Author

yussufsh commented Mar 8, 2024

/cc @Prajyot-Parab @pravin-dsilva

@yussufsh
Allow overriding bastion storage pool
d46764b 
Fixes ocp-power-automation#520

Signed-off-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pravin-dsilva, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pravin-dsilva
Copy link
Collaborator

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit c2e329b into ocp-power-automation:main Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravin-dsilva pravin-dsilva pravin-dsilva approved these changes

@sajauddin sajauddin Awaiting requested review from sajauddin

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

@pravin-dsilva pravin-dsilva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using non-exist storage pool during openshift deploy
3 participants
@yussufsh @ppc64le-cloud-bot @pravin-dsilva