Fix error in grammatical case for German translations #193
Conversation
| { | ||
| result = getPluralName(d); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| protected boolean isPlural(final Duration d, boolean round) { |
There was a problem hiding this comment.
Just a heads up:
I extracted this to a separate method here because I need to do the exact same check inside my custom DeTimeFormat and like to prevent duplicate code. I think it might generally come in handy to have this method available when implementing a custom TimeFormat.
There was a problem hiding this comment.
I agree. This is fine. Consumers of individual resource bundles may need this information. They may also wish to override the functionality, which would require some ... fun... but this would at least make things a bit more discoverable. I don't see any problems with exposing this here.
|
It looks like my IntelliJ IDEA did some whitespace-only changes to existing code when i hit the "reformat" shortcut. In case you are not aware of that:
|
|
@hertg Thank you very much for this PR, and my apologies for the delay! We've been busy getting our release of the new www.topdecked.com ready for public use, and a few things have slipped by. Looking at this now. |
|
Looks great! All tests passing, and I agree with your changes. Merged! |
This fixes the issues mentioned in the original post at #175.
However, the issue still persists when calling
formatDuration(Duration)with a precise Duration that contains multiple units inside the same string.E.g. The following test would still fail:
That's because with the current API and without the necessary context information, this can't be solved without doing really dirty workarounds.
All the tests I've added run successfully. Funny enough, some of the others tests fail. But that was already the case before I applied my changes. Might be related to my system (?), would be good if anybody could take a look at that.