Allow --sidecar along --pages

[dimakuz]

After a few short checks it looks like --sidecar and --pages can work together and produce reasonable results.
This PR relaxes this constraint and prints skipped pages as ranges.

[jbarlow83]

Thank you.

Because this contribution exceeds 10 lines of code, which for some reason is the magic number:

• Is this contribution your own work and not someone else's?
• Do you agree to allow your contribution to be redistributed under the project's current license (MPL 2.0) or any open source license the project may adopt in the future?
• Do you have the legal authority to grant this permission? (e.g. you did not do work under a contract where an employer or client may have legal rights)

If you answer yes to all, we can proceed.

Also, would you mind adding a quick unit test to verify that enumerate_compress_ranges works as designed?

[dimakuz]

Hi @jbarlow83,
Thanks for the quick response!
The answer to all questions is yes. And sure, I'll add some tests later on today. Where would they ideally go? I see that test_pipeline.py references _pipeline module but I can put them wherever you prefer.

[jbarlow83]

Test_pipeline would be fine

…

On Thu., Feb. 18, 2021, 02:44 Dima Kuznetsov, ***@***.***> wrote: Hi @jbarlow83 <https://github.com/jbarlow83>, Thanks for the quick response! The answer to all questions is yes. And sure, I'll add some tests later on today. Where would they ideally go? I see that test_pipeline.py references _pipeline module but I can put them wherever you prefer. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#735 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN5YM7IQTUPWUODMTARRHDS7TVRDANCNFSM4XZA3UJA> .

[dimakuz]

@jbarlow83 I've added the test cases but CI seems to have run into some issue while running the tests.

[jbarlow83]

Thanks for the tests. Looks like a pure CI issue. I'll prod it to try again later.

…

On Fri., Feb. 19, 2021, 02:10 Dima Kuznetsov, ***@***.***> wrote: @jbarlow83 <https://github.com/jbarlow83> I've added the test cases but CI seems to have run into some issue while running the tests. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#735 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN5YM5LJ7IUFTMY5EWFPO3S7Y2KNANCNFSM4XZA3UJA> .