Add user_inventory event class and associated person profile #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tharp, Matthew <Matthew_Tharp2@comcast.com>
Signed-off-by: Tharp, Matthew <Matthew_Tharp2@comcast.com>
…ocumenting user office location Signed-off-by: Tharp, Matthew <Matthew_Tharp2@comcast.com>
Signed-off-by: Tharp, Matthew <Matthew_Tharp2@comcast.com>
Signed-off-by: Tharp, Matthew <Matthew_Tharp2@comcast.com>
mtharp0
requested review from
rroupski,
jp-harvey,
jasonbreimer and
pagbabian-splunk
rroupski
requested changes
Jun 9, 2023
Signed-off-by: Tharp, Matthew <Matthew_Tharp2@comcast.com>
mtharp0
force-pushed
the
add_user_inventory
branch
from
e7a3369
to
32fe06b
Compare
rroupski
approved these changes
Jun 14, 2023
jasonbreimer
approved these changes
Jun 15, 2023
rroupski
approved these changes
Jun 16, 2023
pagbabian-splunk
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to get collected AD type data into OCSF, we are adding a new event class called
user_inventory. It would collect a lot more attributes associated with a user (person). So, in addition to the new class there is a new person profile that allows us to dynamically add the extended attributes to the user for the user_inventory class (or anywhere else that someone may want to add these attributes to theuserobject. In order to allow the user location to be specified without the coordinates in a location, we make the coordinates recommended and add constraints to thelocationobject. Finally, the new attributes are added to the dictionary.