Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 696: Add NTP Event Class #705

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Issue 696: Add NTP Event Class #705

merged 8 commits into from
Aug 17, 2023

Conversation

Aniak5
Copy link
Contributor

@Aniak5 Aniak5 commented Aug 1, 2023

Related Issue: #696

Description of changes:

  • Add NTP attributes and NTP event class
image

@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Aug 1, 2023
@Aniak5 Aniak5 requested a review from rroupski August 1, 2023 17:39
@Aniak5 Aniak5 self-assigned this Aug 1, 2023
events/network/ntp.json Show resolved Hide resolved
dictionary.json Show resolved Hide resolved
dictionary.json Outdated Show resolved Hide resolved
rroupski
rroupski previously approved these changes Aug 2, 2023
mikeradka
mikeradka previously approved these changes Aug 8, 2023
rroupski
rroupski previously approved these changes Aug 11, 2023
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
…in ntp class

Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@floydtree floydtree merged commit 71d307d into ocsf:main Aug 17, 2023
1 check passed
@Aniak5 Aniak5 added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants