Refactor the finding object and base class #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on PR #763 The new finding_info object. It is meant to replace the PR #763. The original security finding class has been restored. The existing finding object has been deprecated. New finding_info object to replace the deprecated finding object. Rename the kill chain object. Signed-off-by: Roumen Roupski <rroupski@splunk.com>
rroupski
added
enhancement
rroupski
requested review from
pagbabian-splunk,
floydtree,
mikeradka,
irakledibm and
maxhotta
|
Aside from my two comments, it looks good to me. |
irakledibm
approved these changes
Sep 7, 2023
maxhotta
approved these changes
Sep 7, 2023
floydtree
requested changes
Sep 8, 2023
floydtree
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on 09/07/2023 meeting discussions
Roughly based on PR #763 The new
finding_infoobject, and it is meant to replace the PR #763.Related issue: #762 New
finding_infoattribute as a successor to the current finding attribute.The original
security_findingclass has been restored (to keep backwards compatibility).The existing
findingobject has been deprecated.New
finding_infoobject to replace the deprecated finding object.Rename the kill chain object.